Interstitial bareground - #1577
Conversation
This reflects that the output will be a fraction dependent on certain logic having to do with handling bareground
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
| bare_frac_area = (1.0_r8 - local_patch_fraction) * & | ||
| (currentPatch%area/AREA) | ||
|
|
||
| total_patch_area = total_patch_area + bc_out(s)%canopy_fraction_pa(ifp) + bare_frac_area |
There was a problem hiding this comment.
Note that this is dead code being removed (total_patch_area). It wasn't being used downstream.
| bc_out(s)%z0m_pa(ifp) = EDPftvarcon_inst%z0mr(1) * bc_out(s)%htop_pa(ifp) | ||
| bc_out(s)%displa_pa(ifp) = EDPftvarcon_inst%displar(1) * bc_out(s)%htop_pa(ifp) | ||
| bc_out(s)%dleaf_pa(ifp) = EDPftvarcon_inst%dleaf(1) |
There was a problem hiding this comment.
Q: Is this still valid regardless of the inclusion of interstitial bareground or not? Or do we need a different calculation if there truly is no canopy? What do HLM's use for pure bareground in this case?
There was a problem hiding this comment.
Note that this needs to be changed as skipping this sets z0m_pa to zero in the host land model and causes a run failure in ch4mod due to (I think) a division by zero in the friction velocity calculation causing h20soi_vol to become NaN downstream. Does that sound likely to you @rgknox ?
| weight = min(1.0_r8,currentCohort%c_area/currentPatch%total_canopy_area) | ||
| weight = min(1.0_r8,currentCohort%c_area/weighting_area) | ||
| bc_out(s)%z0m_pa(ifp) = bc_out(s)%z0m_pa(ifp) + & | ||
| EDPftvarcon_inst%z0mr(currentCohort%pft) * currentCohort%height * weight |
There was a problem hiding this comment.
Q: Does more of this calculation need to change if we are including the interstitial bareground?
389f7e8 to
f8dc5ff
Compare
f8dc5ff to
c20ceb3
Compare
1 participant
Changes how FATES handles interstitial bareground
Description:
CLM associated pull request is ESCOMP/CTSM#4094
Relevant reference: CTSM technical note on MOST
Collaborators:
@ckoven
Expectation of Answer Changes: Yes
Description of generative AI usage (as necessary)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: