fix(ui): resolve file-browser license title and ignore invalid selected ids - #1545
Open
vcnainala wants to merge 1 commit into
Open
fix(ui): resolve file-browser license title and ignore invalid selected ids#1545vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
…ed ids Declare the study prop, derive download-terms license from project or study, and skip empty or non-numeric selected query params so the URL stays valid.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #1545 +/- ##
=================================================
- Coverage 80.26% 80.25% -0.01%
Complexity 4481 4481
=================================================
Files 293 293
Lines 16424 16424
=================================================
- Hits 13182 13181 -1
- Misses 3242 3243 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
studyprop and compute download-termslicenseTitlefrom project or study so Vue no longer reads an undeclaredstudyin the template.selectedquery params so the file browser does not writeselected=undefinedinto the URL.Test plan
?selected=and confirm the URL is not updated withundefined.php artisan test --filter=FileSystemBrowserLicenseTitleTest