Skip to content

fix(ui): resolve file-browser license title and ignore invalid selected ids - #1545

Open
vcnainala wants to merge 1 commit into
developmentfrom
fix/file-browser-license-and-selected-url
Open

fix(ui): resolve file-browser license title and ignore invalid selected ids#1545
vcnainala wants to merge 1 commit into
developmentfrom
fix/file-browser-license-and-selected-url

Conversation

@vcnainala

Copy link
Copy Markdown
Member

Summary

  • Declare the study prop and compute download-terms licenseTitle from project or study so Vue no longer reads an undeclared study in the template.
  • Ignore empty or non-numeric selected query params so the file browser does not write selected=undefined into the URL.

Test plan

  • Open a public study file browser and confirm the download-terms modal shows the study license title.
  • Select a file, then clear/invalid ?selected= and confirm the URL is not updated with undefined.
  • php artisan test --filter=FileSystemBrowserLicenseTitleTest

…ed ids

Declare the study prop, derive download-terms license from project or study, and skip empty or non-numeric selected query params so the URL stays valid.
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (8681915) to head (52180fd).

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1545      +/-   ##
=================================================
- Coverage          80.26%   80.25%   -0.01%     
  Complexity          4481     4481              
=================================================
  Files                293      293              
  Lines              16424    16424              
=================================================
- Hits               13182    13181       -1     
- Misses              3242     3243       +1     
Flag Coverage Δ
unittests 80.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant