feat(hifsa): add 3D assignment viewer and public HiFSA panels - #1543
Open
vcnainala wants to merge 1 commit into
Open
feat(hifsa): add 3D assignment viewer and public HiFSA panels#1543vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Parse Cosmic Truth structures and atom maps, filter EXTRA/hifsa paths out of NMRium loads, and show HiFSA scores on public study, sample, and dataset pages.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## development #1543 +/- ##
=================================================
+ Coverage 80.26% 80.35% +0.09%
- Complexity 4481 4566 +85
=================================================
Files 293 295 +2
Lines 16424 16597 +173
=================================================
+ Hits 13182 13336 +154
- Misses 3242 3261 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spinsystems.sdfandOUTPUT.jsonatom maps into studyhifsa_data, and hide sentinel shift/coupling values.HifsaPanelon upload, dashboard datasets, and public study/sample/dataset pages.fileFilterthat excludesEXTRA/andhifsa/paths so Cosmic Truth artifacts are not loaded as spectra.This app does not use Filament. Backend helpers follow Laravel 13 conventions (typed support classes, API resource
when(), eager-loadedsample.moleculesfor the datasets view).Test plan
hifsa_datais present, and hide it when absent.php artisan test --filter='HifsaAtomLabelsTest|HifsaNmriumFileFilterTest|DraftHifsaPdfTest|PublicHifsaViewTest'