Repository navigation
feat(deploy)!: one-trip login → deploy; remove --wallet - #898
Open
elliotBraem wants to merge 1 commit into
Open
elliotBraem wants to merge 1 commit into
elliotBraem wants to merge 1 commit into
Conversation
`bos login` now installs everything `bos deploy` needs in one browser approval: the scoped deploy key (bundles:write, account/gateway scoped) as the session credential, plus a registry-scoped delegate key the wallet adds to the account (kept in .bos/session.json, reused across re-logins). `bos deploy` then publishes through the gasless NEP-366 relay with no keychain and no env vars; any remaining approval happens before the build. BREAKING: --wallet is removed from publish, deploy, rollback and promote. - signing mode resolves explicitly: --private-key > publish.auth > available key (env / ~/.near-credentials) > login session - preflight plan carries one validated `signing` arm (session | custody | key) instead of useWallet/useCustody/strategy - session mode only when the session account equals the config account - login site derives from the extends-chain root (--site overrides) - cdn.upload joins cdn.origin as an authored field (no BOS_STORAGE_ORIGIN) - custody: preflight gas-balance gate; createDeployKey accepts the custody wallet's hex account - a failed deploy-key mint degrades to a plain session key with a warning - approve page skips the key step when no/mismatched wallet is connected
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before: three trips and a pile of env vars. After: one.
Signing mode resolves explicitly, and the preflight plan carries one validated
signingarm instead ofuseWallet/useCustody/ optionalstrategy:Also:
cdn.uploadjoinscdn.originas an authored field (inherited viaextends)extendsroot;--siteoverrides (needed for a local stack)createDeployKeyaccepts the custody wallet's hex accountEvidence
bos deploy --walletopened a second browser approval after build + upload; a session with no NEAR account passed preflight then threw at submit; custody in CI failed with "No signing key available".After:
tsc --noEmitclean across all 13 workspaces pluseverything-dev/every-plugin/better-near-auth;lint:effectclean (pre-push gate)cdn-deploy,cli-flags,auth-login,custody-signer,publish-auth-guard,publish-preflight-orderall passNot run:
plugins/authintegration test for custody deploy keys, and no end-to-end run against a live login/relay.Merge Danger
Door: one-way for CLI consumers.
--walletis removed outright (breaking), and signing precedence changes.Blast Radius: CLI users and CI
--walletis gone frompublish,deploy,rollback,promote. Nothing in workflows or templates uses it; docs and tests updated.NEAR_PRIVATE_KEY/~/.near-credentials) now outranks the login session, so a stale key keeps you on key signing until removed.bos loginagainst this repo no longer defaults to the local dev UI; pass--sitefor a local stack.--key.publish.verification+ session mode still needs a local key (train.ts). Custody still takes two logins plus a manual config edit.