Repository navigation
Conversation
Template sync applied with --force; activity's own edits to api/plugin.dev.ts, api/tsconfig.json and the biome ignore list are kept. The UI client now goes through everything-dev/ui/api, since every-plugin's createRpcClient is a bare client from rc.44 (everything-dev #849). Records bos.lock.json.
…ttachment Replace the hand-rolled REST fetch in nearbuilders-projects.ts with the plugins.projects attachment (nearbuilders.org#plugins.projects, proxy https://nearbuilders.org), typed by bos types gen. NearbuildersProject is now picked from the deployed contract instead of a local interface. The link/slug/id parsing, host allowlist, search limits and error messages are unchanged; NOT_FOUND still maps to a missing project, other upstream errors to SERVICE_UNAVAILABLE. The nearbuildersApiUrl variable is gone. Closes NEARBuilders#124
adenarc
marked this pull request as ready for review
November 12, 2026 07:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Stacked on #125 (the rc.44 upgrade). Please merge that first; until then this diff includes its commit.
api/src/services/nearbuilders-projects.tsno longer fetches nearbuilders.org's REST API with a hand-writtenNearbuildersProjectinterface. It now goes through aplugins.projectscontract+proxy attachment:getProjectBySlug,getProjectandlistProjects, typed bybos types gen.NearbuildersProjectis now picked from the deployed contract's types.datastill says "unexpected response". Other upstream errors are still SERVICE_UNAVAILABLE, but the text now shows the oRPC code instead of the HTTP status.nearbuildersApiUrlvariable is removed.bos.lock.jsonis refreshed.projectsattachment to the test runtime instead of mockingfetch.Tested:
pnpm run typecheck,pnpm run lintandpnpm run testare green (api 205, ui 110). I also called nearbuilders.org's live/api/rpc/projects/{getProjectBySlug,getProject,listProjects}. All three return the expected shapes, and an unknown slug comes back as a 404NOT_FOUND.Browser check (local stack, Brave, signed out and signed in): signed out, the home page renders and
/activity-sourcesand/bindingredirect to sign-in. Signed in, project search lists live nearbuilders.org results. Picking one fills in the Source ID, display name and owner account. Pasting a link to a missing project shows "No nearbuilders.org project exists at …". An agent binding session created from a project link opens/bindingprefilled. There's no visual change: the pages look the same as on main, and only the transport underneath moved. The account switcher is blurred in the screenshots.