Repository navigation
fix(release): stop invoking postinstall/version scripts removed by rc.39 - #120
Merged
Merged
Conversation
PR #119 (everything-dev 2.0.0-rc.39) removed the postinstall, version, changeset, and release scripts from package.json per the framework's child-template convention (#572 removes changesets glue from children). The Release workflow still called two of them: - 'Run postinstall' failed with ERR_PNPM_NO_SCRIPT (run 42084938527), so the drop removes the step — nothing downstream needs generated types: 'changeset version' is file ops and the GH-release step is jq/sed. - The changesets action's 'version: pnpm run version' would fail the same way on the next run (5 pending changesets on main), so it now invokes the devDependency binary directly via 'pnpm exec changeset version'. No package.json changes: keeping it aligned with the rc.39 template means the next bos upgrade won't clobber the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release (Version Packages) workflow fails on main since #119 — see run 42084938527:
The everything-dev 2.0.0-rc.39 upgrade removed the
postinstall,version,changeset, andreleasescripts frompackage.jsonper the framework's child-template convention (upstream #572 removes the changesets glue from children). The workflow still invoked two of them.Fix (workflow-only)
Run postinstallstep — nothing downstream in this workflow needs generated types:changeset versionis pure file ops, and the GH-release step is jq/sed.version: pnpm run version→version: pnpm exec changeset version— the changesets action would have hitMissing script: versionnext (there are 5 pending changesets on main); this calls the@changesets/clidevDependency binary directly.No
package.jsonchanges: keeping it aligned with the rc.39 template means the nextbos upgradewon't clobber this.Verification
chore: version packagesPR (which also un-stales the currently CONFLICTING chore: version packages #88)