require compiled Boost variants for uhal dependencies - #77
Open
corrodis wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the Spack dependency specification for uhal by requiring the specific compiled Boost components that uhal links against, avoiding configurations where a header-only Boost would satisfy the dependency but fail at link time.
Changes:
- Replace the generic
depends_on("boost")with a Boost spec that enables the needed compiled libraries. - Add an in-file comment documenting why compiled Boost libraries are required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eflumerf
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this change for a fresh, clean install on mgr-01.