Repository navigation
Revert driving the tool-mount servo: it is a leftover, not a tool - #39
Merged
Merged
Conversation
This reverts commit e5573ba. The continuous SG90 clamped in the tool mount was put there for a gripper the arm was first designed to carry. The arm draws instead, and the owner has said the tip must not turn: that servo drives nothing. So the driver no longer takes it as a speed interface, the description no longer gives it one, and tool_controller, its spawner and its dependency on forward_command_controller go with them. The tree is back to c28e46e byte for byte, which is the tree the full test suite last certified. The places that still describe that servo as driving the tool are corrected in the next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e5573ba.
The continuous SG90 clamped in the tool mount was put there for a gripper the arm was first designed to carry. The arm draws instead, and the owner has said the tip must not turn: that servo drives nothing. So the driver no longer takes it as a speed interface, the description no longer gives it one, and tool_controller, its spawner and its dependency on forward_command_controller go with them.
The tree is back to c28e46e byte for byte, which is the tree the full test suite last certified. The places that still describe that servo as driving the tool are corrected in the next commit.