Skip to content

fix(network): skip sysctl/modprobe on non-Linux in NoopNetworkPlugin #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(network): skip sysctl/modprobe on non-Linux in NoopNetworkPlugin #564

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c981b
fix(network): skip sysctl/modprobe on non-Linux in NoopNetworkPlugin
AruneshDwivedi Jun 26, 2026
2d8662b
test(network): add non-Linux test for NoopNetworkPlugin.Init
AruneshDwivedi Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions network/plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package network
import (
"fmt"
"net"
"runtime"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -217,6 +218,10 @@ func (plugin *NoopNetworkPlugin) Init(
// depending on whether or not they connect containers to Linux bridges
// or use some other mechanism (ie, SDN vswitch).

if runtime.GOOS != "linux" {
return nil
}
Comment on lines +221 to +223

// Ensure the netfilter module is loaded on kernel >= 3.18; previously
// it was built-in.
utilexec.New().Command("modprobe", "br-netfilter").CombinedOutput()
Expand Down
Loading