This repository was archived by the owner on Jun 25, 2026. It is now read-only.
Drop graduation changes from protocol - #31
Merged
Merged
Conversation
nishu-builder
pushed a commit
to Metta-AI/coworld
that referenced
this pull request
Jun 15, 2026
## Summary - remove `RoundComplete.graduation_changes` from the packaged Coworld commissioner protocol - stop applying the container round-complete graduation fallback as champion membership events - keep `policy_membership_events` plus legacy `membership_changes` as the supported membership-change paths - update Coworld commissioner docs to direct new commissioners to `policy_membership_events` ## Paired PR - Commissioners protocol update: Metta-AI/commissioners#31 ## Validation - PASS: `PYTHONPATH=app_backend/src:packages/coworld/src:packages/metta-common/src /home/kyleherndon/metta/.venv/bin/python -m pytest app_backend/tests/v2/test_container_commissioner_pipeline_integration.py app_backend/tests/v2/test_commissioner_driver.py packages/coworld/tests/test_commissioner_protocol.py -q` (`52 passed`) - PASS: `/home/kyleherndon/metta/.venv/bin/python -m ruff check app_backend/src/metta/app_backend/v2/pipeline.py app_backend/tests/v2/test_container_commissioner_pipeline_integration.py app_backend/tests/v2/test_commissioner_driver.py packages/coworld/src/coworld/commissioner/protocol.py packages/coworld/src/coworld/commissioner/__init__.py packages/coworld/tests/test_commissioner_protocol.py` - PASS: `/home/kyleherndon/metta/.venv/bin/python -m ruff format --check app_backend/src/metta/app_backend/v2/pipeline.py app_backend/tests/v2/test_container_commissioner_pipeline_integration.py app_backend/tests/v2/test_commissioner_driver.py packages/coworld/src/coworld/commissioner/protocol.py packages/coworld/src/coworld/commissioner/__init__.py packages/coworld/tests/test_commissioner_protocol.py` - PASS: `git diff --check` - BLOCKED: `env METTA_USE_NIX=0 metta lint` fails locally while building `mettagrid`; Bazel reports `nix_closure: nix not found on PATH or any common install location`. Retried with network approval after an initial sandbox DNS failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraduationChangeandRoundComplete.graduation_changesfrom the commissioner protocolgraduation_changesin adapter/ruleset round-complete responsespolicy_membership_eventsand legacymembership_changesValidation
PYTHONPATH=. /home/kyleherndon/commissioners-main/.venv/bin/python -m pytest tests/test_commissioner_strategies.py::test_extended_hook_adapters_map_internal_models_to_protocol_models tests/test_commissioner_websocket.py::test_protocol_accepts_prefixed_round_public_id_and_episode_completed_response -q(2 passed)PYTHONPATH=. /home/kyleherndon/commissioners-main/.venv/bin/python -m compileall -q commissioners/common/protocol.py commissioners/common/adapters.py commissioners/common/ruleset_strategy/commissioner.pygit diff --checkpyproject.tomlonly defines pytest dev dependencies.uv run ruff --versionfails because ruff is not installed/configured.tests/test_commissioner_strategies.py tests/test_commissioner_websocket.pyrun was stopped after hanging beyond 3 minutes after initial progress.