Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Redis-backed response caching added in #603 had no way to confirm from outside the process whether a given response actually came from the cache or was recomputed — checking required either comparing response timings or inspecting Redis keys directly via
redis-cli.Every response that goes through
cache.get()/cache.set()—retrieve,list,issue_list-style detail actions, andPublisherViewSet.series_list— is now tagged with anX-Cache: HITorX-Cache: MISSheader via a shared_mark_cache_status()helper, so it's a plaincurlaway:A viewset/action with caching disabled (
Collection/PullList/WishList/ReadingList— user-scoped, never cached) gets no header at all rather than a misleadingMISS, so the header's presence also doubles as confirmation that caching applies to a given endpoint at all.Test plan
MISSon first request andHITon the immediate repeat.X-Cacheheader.