Skip to content

Allow disabling indexing - #31

Open
StorytellerCZ wants to merge 6 commits into
Meteor-Community-Packages:mainfrom
StorytellerCZ:feature/disable-indexing
Open

Allow disabling indexing#31
StorytellerCZ wants to merge 6 commits into
Meteor-Community-Packages:mainfrom
StorytellerCZ:feature/disable-indexing

Conversation

@StorytellerCZ

Copy link
Copy Markdown
Member

Per #17 this PR allows to set Meteor.settings.collection2.dontRunIndexing to true which will then disable the indexing functionality.

To discuss here is that maybe we should enable this only for development.

@harryadel

harryadel commented Jan 16, 2024

Copy link
Copy Markdown
Member

I don't really see the point?? Why not remove the indexes you created? A big kill switch isn't that big of a deal really. Especially given how simple it's to use this packages index: 1 How hard it's for you to search the code and remove those statements?? 👎

@StorytellerCZ

Copy link
Copy Markdown
Member Author

Simple answer: packages
If you have a package that depends on this package and sets indexes via collection2, then unless you have this option or manually edit the target package you have to do things manually in MongoDB and every time your server updates.

@harryadel

Copy link
Copy Markdown
Member

like what packages?

@StorytellerCZ

StorytellerCZ commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

Socialize packages, freedombase:legal-management, etc.

In general feature packages that add collections.

@harryadel

Copy link
Copy Markdown
Member

ok, fair enough.

@StorytellerCZ

Copy link
Copy Markdown
Member Author

@jankapunkt can I ask you for a quick review and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow disabling of indexing with an environment variable or Meteor.setting

2 participants