Allow disabling indexing - #31
Open
StorytellerCZ wants to merge 6 commits into
Open
Conversation
Member
|
I don't really see the point?? Why not remove the indexes you created? A big kill switch isn't that big of a deal really. Especially given how simple it's to use this packages |
Member
Author
|
Simple answer: packages |
Member
|
like what packages? |
Member
Author
|
Socialize packages, freedombase:legal-management, etc. In general feature packages that add collections. |
Member
|
ok, fair enough. |
harryadel
approved these changes
Jan 16, 2024
Member
Author
|
@jankapunkt can I ask you for a quick review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #17 this PR allows to set
Meteor.settings.collection2.dontRunIndexingto true which will then disable the indexing functionality.To discuss here is that maybe we should enable this only for development.