Skip to content

fix(settings): update notifications settings copy and casing#32922

Open
andrewjcohen wants to merge 2 commits into
mainfrom
fix/notifications-settings-content
Open

fix(settings): update notifications settings copy and casing#32922
andrewjcohen wants to merge 2 commits into
mainfrom
fix/notifications-settings-content

Conversation

@andrewjcohen

@andrewjcohen andrewjcohen commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Updates copy in the Notifications settings screen to match current content guidelines. Section titles now use sentence case (e.g. "Wallet activity" instead of "Wallet Activity"), the wallet activity description no longer mentions rewards, and the "curated" typo in the trading signals description is fixed. Related unit tests are updated to match the new strings.

Changelog

CHANGELOG entry: Updated notification settings section titles and descriptions

Related issues

Refs: content update — no linked issue

Manual testing steps

Feature: Notifications settings copy

  Scenario: user views updated notification section labels
    Given the user has notifications enabled in Settings
    And the app language is set to English

    When user navigates to Settings > Notifications
    Then section titles display sentence case (e.g. "Wallet activity", "Trading activity", "Price alerts")
    And the wallet activity description reads "Buy, sells, transfers, swaps"
    And the trading signals description reads "Updates from traders and assets you follow, plus curated market news"

Screenshots/Recordings

N/A — copy-only change with no visual layout differences.

Before

Screenshot 2026-07-07 at 4 53 57 PM Screenshot 2026-07-07 at 4 53 52 PM Screenshot 2026-07-07 at 4 53 46 PM Screenshot 2026-07-07 at 4 53 42 PM

After

Screenshot 2026-07-07 at 4 40 38 PM Screenshot 2026-07-07 at 4 40 32 PM Screenshot 2026-07-07 at 4 40 28 PM Screenshot 2026-07-07 at 4 40 23 PM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Align notification section titles and descriptions with updated content guidelines, fix the curated typo, and update related tests.
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-design-system All issues relating to design system in Mobile label Jul 7, 2026
@mm-token-exchange-service

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've documented my code using JSDoc format if applicable"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions github-actions Bot added the size-S label Jul 7, 2026
@andrewjcohen andrewjcohen self-assigned this Jul 7, 2026
AI overshot a tad, fixing unnecessary caps.
@andrewjcohen andrewjcohen marked this pull request as ready for review July 7, 2026 22:58
@andrewjcohen andrewjcohen requested review from a team as code owners July 7, 2026 22:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 102f308. Configure here.

title: 'Trading Signals',
description:
'Updates from traders and assets you follow, plus currated market news',
'Updates from traders and assets you follow, plus curated market news',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale socialAI title in test

Medium Severity

This commit changes social_ai_title in en.json to Trading signals, and TopTradersView passes that locale value into navigation params. The socialAI notification navigation test still expects Trading Signals, so mockNavigate assertions no longer match runtime behavior and the test fails.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 102f308. Configure here.

@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium AI analysis: medium risk size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant