fix(activity): show pooled-staking as "Staked/Unstaked Ethereum"

[vinnyhoward]

Description

Pooled-staking (ETH) deposits were mapped to the generic deposit activity kind and rendered in the redesigned Activity list as the ambiguous "Deposited ETH", even though the opposite action was already correctly labeled "Unstaked ETH".

This adds a dedicated stake activity kind so pooled-staking deposits read "Staked Ethereum", and relabels unstake to "Unstaked Ethereum" for symmetry (both use the full asset name). The shared deposit kind could not simply be relabeled — it also backs ramp fiat deposits and the Accounts API DEPOSIT category, which must stay "Deposited".

What changed:

• New stake kind in the activity-adapter types, with TransactionType.stakingDeposit mapping to it.
• Row title logic emits "Staked Ethereum" / "Unstaked Ethereum".
• Icon resolver, transaction-details TemplateLoader routing, and the DepositDetails prop type updated for the new kind.
• Unit tests updated/added (adapter mapping, row titles, details routing).

Scope note: this covers the local (typed) transaction path, which is the reported repro. A separate follow-up will address staking labels being lost when the Accounts API is the only source (e.g. after an uninstall/reinstall).

Changelog

CHANGELOG entry: Fixed ETH pooled-staking activity labels to read "Staked Ethereum" and "Unstaked Ethereum" instead of the ambiguous "Deposited ETH".

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-1000

Manual testing steps

Feature: Pooled-staking activity labels

  Scenario: Staking deposit is labeled by intent
    Given I have ETH available to stake
    When I complete a pooled-staking deposit via the Earn CTA next to Ethereum
    And I open the Activity list
    Then the activity row reads "Staked Ethereum" (not "Deposited ETH")

  Scenario: Unstake label uses the full asset name
    Given I have a pooled-staking position
    When I unstake and open the Activity list
    Then the activity row reads "Unstaked Ethereum"

Screenshots/Recordings

Before

"Deposited ETH" on pooled-staking deposit rows. Screenshot to be attached.

After

"Staked Ethereum" / "Unstaked Ethereum". Screenshot to be attached.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Display and classification changes for staking on the local transaction path only; generic deposit behavior is preserved and tests were updated.

Overview
Introduces a dedicated stake activity kind so pooled ETH staking deposits are no longer classified as generic deposit (which must stay "Deposited" for ramps and API deposits).

TransactionType.stakingDeposit now maps to stake in the local transaction adapter. List rows use "Staked Ethereum" / "Unstaked Ethereum" (full asset name, not ETH), with stake using the outbound/send icon family. Activity details route stake through DepositDetails like unstake.

Row title helpers move into titleLabels.ts (TOKEN_ACTION_LABELS, fallback resolvers). stake is included in the Transactions type filter and covered by updated adapter, row, details, and filter tests.

^{Reviewed by Cursor Bugbot for commit c7801e5. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[mm-token-exchange-service]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[vinnyhoward]

Pulling out resolvers from app/components/UI/ActivityListItemRow/useActivityListItemRowContent.ts

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeStake, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new stake ActivityKind to distinguish staking deposits from generic deposits in the activity/transaction history system. Key changes:

1. local-transaction.ts: TransactionType.stakingDeposit now maps to type: 'stake' instead of type: 'deposit' — this is a behavioral change affecting how staking transactions appear in the activity list.

2. types.ts (activity-adapters): Added 'stake' to the ActivityKind union and the ActivityData type union.

3. resolveIconType.ts: Added 'stake' case so staking transactions get the correct icon.

4. titleLabels.ts (new file): Extracted title/label constants from useActivityListItemRowContent.ts, adding stake/unstake labels ("Staked", "Staking", "Stake failed").

5. useActivityListItemRowContent.ts: Added 'stake' case with special "Staked Ethereum" display noun (since pooled staking is ETH-only).

6. TemplateLoader.tsx + DepositDetails.tsx: Added 'stake' routing to the DepositDetails template for the activity detail view.

7. ActivityScreen/types.ts: Added 'stake' to ACTIVITY_TYPE_FILTER_KINDS under Transactions filter.

Tag selection rationale:

• SmokeStake: Directly tests staking flows — the staking deposit transaction type now maps to a new stake kind, affecting how staking activity appears in the activity list and detail views.
• SmokeWalletPlatform: Tests transaction history display, which is directly affected by the new stake kind changing how staking transactions are labeled and displayed.
• SmokeConfirmations: Required per SmokeStake tag description ("when selecting SmokeStake, also select SmokeConfirmations").

No other tags are needed — this change is scoped to staking activity display and doesn't affect swaps, network management, accounts, browser, snaps, or other flows.

Performance Test Selection:
The changes are purely about activity list item rendering logic and type mappings for staking transactions. There are no changes to performance-sensitive paths like app launch, login, onboarding, asset loading, or swap flows. The refactoring of title labels into a separate file and adding a new 'stake' kind are not expected to have any measurable performance impact.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud