fix(TMCU-801): migrate GlobalAlert and SimpleNotification off scrim tokens#32914
fix(TMCU-801): migrate GlobalAlert and SimpleNotification off scrim tokens#32914georgewrmarshall wants to merge 3 commits into
Conversation
…okens Replace overlay.* scrim tokens in GlobalAlert with elevated surface and semantic text/icon colors for pure-black dark mode compatibility. Remove legacy importedColors usage from SimpleNotification. Add Storybook stories and unit tests for both components. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
None of these changes affect E2E-testable user flows, navigation, transaction confirmations, account management, network management, or any other feature area covered by the available E2E tags. The GlobalAlert theming change only affects the visual appearance of the clipboard copy alert, which is not covered by any specific E2E smoke test scenario. No E2E tags are warranted. Performance Test Selection: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32914 +/- ##
==========================================
+ Coverage 84.41% 84.46% +0.04%
==========================================
Files 5976 5991 +15
Lines 156931 157402 +471
Branches 38183 38283 +100
==========================================
+ Hits 132481 132951 +470
+ Misses 15303 15285 -18
- Partials 9147 9166 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|



Description
This PR fixes pure-black dark mode rendering for
GlobalAlertandSimpleNotification(TMCU-801).GlobalAlertpreviously usedoverlay.alternativeandoverlay.inversescrim tokens for its clipboard banner background and foreground. Under pure-black dark mode, those scrim tokens collapse visually and make the alert hard to read. The banner now usesgetElevatedSurfaceColor(theme)for the background and semantictext.default/icon.defaulttokens for foreground content.SimpleNotificationpreviously imported legacyimportedColorsonly to referencetransparent. That dependency is removed in favor of the literal'transparent'value, which is theme-neutral.Storybook stories were added for both components so they can be verified in isolation. Unit tests cover the token migration.
Changelog
CHANGELOG entry: null
Related issues
Fixes: TMCU-801
Manual testing steps
Screenshots/Recordings
N/A — Storybook stories added for isolated visual QA. Enable
MM_PURE_BLACK_PREVIEW="true"and dark mode for pure-black verification.Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an examplePre-merge reviewer checklist