Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Promise from dispose method #170

Description

@Gudahtt

The dispose method of the keyring calls a dispose function from the Trezor connect that returns a promise, but our method doesn't return that promise. That makes it impossible for the caller to know when this operation has completed. We should return the promise so that it's possible to know when the disposal has completed.

Suggested here: #161 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions