refactor(assets-controller): memoize balance call encodings in Multic…#9423
Closed
salimtb wants to merge 2 commits into
Closed
refactor(assets-controller): memoize balance call encodings in Multic…#9423salimtb wants to merge 2 commits into
salimtb wants to merge 2 commits into
Conversation
…allClient Cache encodeBalanceOf and encodeGetEthBalance per account address to avoid redundant ABI encoding when batching many tokens for the same wallet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…allClient
Cache encodeBalanceOf and encodeGetEthBalance per account address to avoid redundant ABI encoding when batching many tokens for the same wallet.
Explanation
References
Checklist
Note
Low Risk
Internal performance refactor with no API or balance semantics change; risk is limited to ensuring cached calldata stays identical to prior per-request encoding.
Overview
MulticallClient.batchBalanceOfnow builds ERC-20balanceOfand nativegetEthBalancecalldata once per account (case-insensitive) per invocation, instead of re-encoding for every token row in a batch.A per-request
createBalanceCallDataCachebacks multicallaggregate3assembly viabuildAggregate3BalanceCalls, and the same cache is passed through multicall fallback and unsupported-chain single-call paths so ERC-20 fallback reuses encoded calldata. Native balances on those fallback paths still useprovider.getBalance(unchanged).A unit test asserts encoding deduplication (e.g. two
balanceOfand onegetEthBalanceencode for four mixed requests). Changelog updated under Unreleased.Reviewed by Cursor Bugbot for commit 655f6ec. Bugbot is set up for automated code reviews on this repo. Configure here.