Skip to content

feat(keyring-api): add base32 private key encoding#589

Merged
ccharly merged 2 commits into
mainfrom
cc/feat/private-key-base-32
Jul 8, 2026
Merged

feat(keyring-api): add base32 private key encoding#589
ccharly merged 2 commits into
mainfrom
cc/feat/private-key-base-32

Conversation

@ccharly

@ccharly ccharly commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Adding a new encoding for private keys (will be used by Stellar).


Note

Low Risk
Additive enum/struct extension with tests only; no changes to encoding logic or existing format behavior.

Overview
Adds base32 as a supported private key string encoding in the v2 keyring API, alongside existing hexadecimal and base58.

The change extends PrivateKeyEncoding / PrivateKeyEncodingStruct in private-key.ts, so encoding: 'base32' is accepted for private-key import (ImportPrivateKeyFormat, CreateAccountOptions private-key import), export (ExportAccountOptions, ExportedAccount), and related capability format declarations. Runtime validation and TypeScript assignability are covered with new struct and test-d cases; the unreleased changelog notes exportAccount support for this encoding (intended for Stellar).

Reviewed by Cursor Bugbot for commit c41a37f. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly marked this pull request as ready for review July 8, 2026 09:38
@ccharly ccharly requested a review from a team as a code owner July 8, 2026 09:38
@ccharly ccharly changed the title feat(keyring-api): add base32 private key encoding feat(keyring-api): add base32 private key encoding Jul 8, 2026
@ccharly ccharly added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 770cb0f Jul 8, 2026
42 checks passed
@ccharly ccharly deleted the cc/feat/private-key-base-32 branch July 8, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants