feat(keyring-api): add base32 private key encoding#589
Merged
Conversation
base32 private key encoding
montelaidev
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new encoding for private keys (will be used by Stellar).
Note
Low Risk
Additive enum/struct extension with tests only; no changes to encoding logic or existing format behavior.
Overview
Adds
base32as a supported private key string encoding in the v2 keyring API, alongside existinghexadecimalandbase58.The change extends
PrivateKeyEncoding/PrivateKeyEncodingStructinprivate-key.ts, soencoding: 'base32'is accepted for private-key import (ImportPrivateKeyFormat,CreateAccountOptionsprivate-key import), export (ExportAccountOptions,ExportedAccount), and related capability format declarations. Runtime validation and TypeScript assignability are covered with new struct andtest-dcases; the unreleased changelog notesexportAccountsupport for this encoding (intended for Stellar).Reviewed by Cursor Bugbot for commit c41a37f. Bugbot is set up for automated code reviews on this repo. Configure here.