Create operational timer: stopwatch - #462
Oakley Brunt (oakleybrunt) wants to merge 17 commits into
Conversation
Steve Mullerworth (stevemullerworth)
left a comment
There was a problem hiding this comment.
I'm tagged as code owner reviewer. I note that the description references use of AI which means that the code should include a comment indicating that Enterprise AI was used (I assume it was) and what model was used.
The requirement comes from operations, but it looks like a generic tool, so maybe the procedure names and file name could be more generic.
Please can API documentation be added to an appropriate section of the Sphinx docs (though I suspect the "official" timer documentation may not have been written with which this approach can be contrasted...).
Did you have anything in mind for the file and type name?
For the procedures, I have dropped the |
I would be slightly concerned that making the name and implied usage too generic would result in people using it when they should be using |
|
|
Steve Mullerworth (@stevemullerworth), Andrew Coughtrie (@andrewcoughtrie) can we decide the naming today please - I'd like to get this wrapped up. |
|
Following up from my comment above, I like stopwatch! Some documentation would still be good! Also, the year number in the copyright statement is no longer required. |
|
Sara Cusworth (@mo-saracusworth) this is ready for review when you have time :) |
PR Summary
Sci/Tech Reviewer: Sara Cusworth (@mo-saracusworth)
Code Reviewer: Steve Mullerworth (@stevemullerworth)
Linked with MetOffice/lfric_apps#652, this PR adds the infrastructure for an operational timer. The implementation is based on Andrew Coughtrie (@andrewcoughtrie)'s suggestions (created with AI assistance), though I have added the ability to pause and resume the timer.
The timer will be called
stopwatchsince it is used in a similar vein to a lap timer.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - stopwatch_core/run1
Suite Information
Task Information
✅ succeeded tasks - 433
Security Considerations
Performance Impact
AI Assistance and Attribution
The original implementation suggested by Andrew Coughtrie (@andrewcoughtrie) was created with the assistance of AI tools.
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review