fix(test-insights): point the framework recipes at a dashboard page that exists - #12417
Conversation
|
This pull request is part of a Mergify stack:
|
Merge Protections🔴 2 of 6 protections blocking · waiting on 👀 reviews
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 4 satisfied protections🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
|
This stack answers three of the four docs asks filed on 2026-08-17 (Mergifyio/ci-bot#369, #370, #372). The fourth, Mergifyio/ci-bot#366, turned out not to be a docs change and is Mergifyio/monorepo#38775 instead. #366 asked whether this repo should grow a section on how a ruleset bypass mode interacts with condition injection, taking the I read the flag that decides it. One thing that fix deliberately does not settle, noted on that PR: the |
c604f0e to
10ece46
Compare
Revision history
|
There was a problem hiding this comment.
Pull request overview
This PR fixes broken/absent “review results in Test Insights” links across the Test Framework recipes by centralizing the CTA into a shared MDX partial that points to the existing Test Insights → Detection dashboard page. It also updates the GitHub Actions recipe snippets to reliably propagate the test step outcome into the quarantine/upload step by adding id: tests (and ensuring continue-on-error: true where required).
Changes:
- Replace per-recipe “review in Test Insights” copy/links with a shared
<ReviewInTestInsights />partial targeting/test-insights/detection. - Add
id: teststo the test-runner step in GitHub Actions examples so${{ steps.tests.outcome }}resolves correctly. - Add missing
continue-on-error: truein the affected workflow examples to match the quarantine setup requirements.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/content/docs/test-insights/test-frameworks/testng.mdx | Adds id: tests to test steps and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/rust.mdx | Adds id: tests to both alternative test steps and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/phpunit.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/pest.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/nunit.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/mstest.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/minitest.mdx | Adds id: tests (and missing continue-on-error: true) to the test steps and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/junit.mdx | Adds id: tests (and missing continue-on-error: true for Gradle) and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/jest.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/golang.mdx | Adds id: tests to the test step and replaces the broken dashboard link with the shared review partial. |
| src/content/docs/test-insights/test-frameworks/cypress.mdx | Adds the shared review partial where the dashboard was previously mentioned without a link. |
| src/content/docs/test-insights/test-frameworks/_review-in-test-insights.mdx | Introduces a reusable “review results” partial linking to the Test Insights Detection page. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
10ece46 to
0ec2b78
Compare
|
@jd this pull request is now in conflict 😩 |
…hat exists Eleven test framework recipes closed by sending the reader to the Test Insights dashboard. Ten of them linked `https://dashboard.mergify.com/test-insights/jobs`, which is not a page: Test Insights has Prevention, Detection and Mitigation, so that URL matched the router and rendered nothing. `jobs` is a CI Insights route, a different and org-scoped surface, which is where the copy-paste came from. The eleventh (Cypress) named the dashboard in the same sentence with no link at all. The paragraph promises "test results, including any failures or flaky tests", and Detection is the page listing flaky and broken tests, so that is where all eleven now point. It is also a partial now, included by the recipes rather than pasted into each. One stale URL became ten broken links precisely because it was ten copies of one sentence, and an eleventh copy had already drifted into a dead end. Separately, two of the recipes' inline GitHub Actions examples were missing the `continue-on-error: true` that the quarantine partial they include requires: without it a failing test step ends the job before the upload step runs, so the run that most needs a report produces none. The `id: tests` half of that fix landed meanwhile in #12439 across the same recipes, so what is left here is the two `continue-on-error` lines. All eleven recipes are fixed here rather than the six the ask named: the six-versus-four split was an artifact of how that audit run was scoped, and leaving four behind keeps the corpus inconsistent. Fixes Mergifyio/ci-bot#372 Part of MRGFY-8720 Change-Id: I482ec81d7710f37d83dcffdf65abc029b73437fc
0ec2b78 to
3d4d468
Compare
|
Rebased onto main and resolved the conflict #12439 landed the What is left in this PR is therefore the dashboard link fix (all eleven recipes, via the new |
Eleven test framework recipes closed by sending the reader to the Test Insights
dashboard. Ten of them linked
https://dashboard.mergify.com/test-insights/jobs, which is not a page: TestInsights has Prevention, Detection and Mitigation, so that URL matched the
router and rendered nothing.
jobsis a CI Insights route, a different andorg-scoped surface, which is where the copy-paste came from. The eleventh
(Cypress) named the dashboard in the same sentence with no link at all.
The paragraph promises "test results, including any failures or flaky tests",
and Detection is the page listing flaky and broken tests, so that is where all
eleven now point.
It is also a partial now, included by the recipes rather than pasted into each.
One stale URL became ten broken links precisely because it was ten copies of
one sentence, and an eleventh copy had already drifted into a dead end.
Separately, two of the recipes' inline GitHub Actions examples were missing the
continue-on-error: truethat the quarantine partial they include requires:without it a failing test step ends the job before the upload step runs, so the
run that most needs a report produces none. The
id: testshalf of that fixlanded meanwhile in #12439 across the same recipes, so what is left here is the
two
continue-on-errorlines.All eleven recipes are fixed here rather than the six the ask named: the
six-versus-four split was an artifact of how that audit run was scoped, and
leaving four behind keeps the corpus inconsistent.
Fixes https://github.com/Mergifyio/ci-bot/issues/372
Part of MRGFY-8720