Skip to content

[NEEDS CODE REVIEWER] fix: Handle failed status requests in SABnzbd check_connected #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lolimmlost wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[NEEDS CODE REVIEWER] fix: Handle failed status requests in SABnzbd check_connected #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/settings/_download_clients_sabnzbd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,21 @@ async def check_connected(self):
"_download_clients_sabnzbd.py/check_connected: Checking if SABnzbd is connected"
)
params = {"mode": "status", "apikey": self.api_key, "output": "json"}
response = await make_request(
"get",
self.api_url,
self.settings,
timeout=self.timeout,
params=params,
)
status_data = response.json()
try:
response = await make_request(
"get",
self.api_url,
self.settings,
timeout=self.timeout,
params=params,
)
status_data = response.json()
except Exception:
logger.warning(
">>> %s: Failed to reach SABnzbd status endpoint. Treating as disconnected.",
self.name,
)
return False
# SABnzbd doesn't have a direct "disconnected" status like qBittorrent
# We check if we can get status successfully
return "status" in status_data
Expand Down
Loading