Skip to content

Refactor world cluster proxy#120

Draft
Krilliac wants to merge 10 commits into
MangosServer:mainfrom
Krilliac:claude/refactor-world-cluster-proxy-LJNDu
Draft

Refactor world cluster proxy#120
Krilliac wants to merge 10 commits into
MangosServer:mainfrom
Krilliac:claude/refactor-world-cluster-proxy-LJNDu

Apply dotnet format auto-fix to new federation/supervisor/admin files

8ead943
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action May 4, 2026 in 0s

146 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 146
           

Complexity increasing per file
==============================
- src/server/Mangos.Cluster/LegacyClusterModule.cs  6
- src/server/Mangos.Cluster/Handlers/WC_Handlers_Group.cs  17
- src/server/Mangos.Cluster/Network/WorldServerClass.cs  26
- src/server/Mangos.World/Network/WS_Network.WorldServerClass.cs  15
- src/server/Mangos.Cluster.Interop/Proxies/ClusterInteropProxy.cs  2
- src/server/Mangos.Cluster.Interop/Protocol/InteropSerializer.cs  5
- src/server/WorldCluster/Program.cs  3
- src/server/Mangos.Cluster.Interop/Dispatchers/ClusterInteropDispatcher.cs  4
- src/server/WorldServer/Program.cs  1
- src/server/Mangos.Cluster.Admin/Auth/PeerAuth.cs  4
- src/server/Mangos.Cluster.Admin/Commands/AdminCommand.cs  7
- src/server/Mangos.Cluster.Admin/Commands/AdminCommandParser.cs  22
- src/server/Mangos.Cluster.Admin/Commands/AdminCommandReply.cs  4
- src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs  14
- src/server/Mangos.Cluster.Admin/Protocol/ChatEnvelope.cs  7
- src/server/Mangos.Cluster.Admin/Protocol/FederationLink.cs  35
- src/server/Mangos.Cluster.Admin/Protocol/FederationServer.cs  15
- src/server/Mangos.Cluster.Admin/Protocol/GroupEnvelope.cs  12
- src/server/Mangos.Cluster.Admin/Protocol/PeerHello.cs  6
- src/server/Mangos.Cluster.Admin/Protocol/PresenceEnvelope.cs  6
- src/server/Mangos.Cluster.Admin/Protocol/ShardEnvelope.cs  5
- src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs  23
- src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs  17
- src/server/Mangos.Cluster/Federation/FederationRouter.cs  50
- src/server/Mangos.Cluster/Federation/RealmMarkers.cs  4
- src/server/Mangos.Cluster/Federation/ShardRegistry.cs  6
- src/server/Mangos.Cluster/Supervision/ClusterAdminCommandHandler.cs  67
- src/server/Mangos.Cluster/Supervision/WorldSupervisor.cs  83
- src/server/Mangos.MySql/GetFederationPeers/GetFederationPeersQuery.cs  2
- src/server/Mangos.MySql/UpdateFederationMarker/UpdateFederationMarkerCommand.cs  3
- src/server/Mangos.World/Handlers/WS_Commands.Admin.cs  17
- src/server/Mangos.Cluster.Interop/ShardLookupResult.cs  2
- src/server/Mangos.Cluster/Federation/FederatedShardClaimer.cs  12
         

Clones added
============
- src/server/Mangos.Cluster/Handlers/WC_Handlers_Group.cs  1
- src/server/Mangos.Cluster/Handlers/WC_Handlers_Chat.cs  1
- src/server/Mangos.Cluster.Admin/Protocol/FederationLink.cs  1
- src/server/Mangos.Cluster.Admin/Protocol/GroupEnvelope.cs  2
- src/server/Mangos.Cluster.Admin/Protocol/PeerHello.cs  2
- src/server/Mangos.Cluster.Admin/Protocol/ShardEnvelope.cs  1
- src/server/Mangos.Cluster/Federation/FederationRouter.cs  1
- src/server/Mangos.Cluster/Federation/ShardRegistry.cs  1
         

Clones removed
==============
+ src/server/WorldCluster/Program.cs  -2

See the complete overview on Codacy

Annotations

Check warning on line 51 in src/server/Mangos.Cluster.Admin/Auth/PeerAuth.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Auth/PeerAuth.cs#L51 

Use the overloading mechanism instead of the optional parameters.

Check warning on line 75 in src/server/Mangos.Cluster.Admin/Commands/AdminCommandParser.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/AdminCommandParser.cs#L75 

Do not update the loop counter 'i' within the loop body.

Check notice on line 139 in src/server/Mangos.Cluster.Admin/Commands/AdminCommandParser.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/AdminCommandParser.cs#L139 

Add curly braces around the nested statement(s) in this 'if' block.

Check warning on line 37 in src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs#L37 

Use the overloading mechanism instead of the optional parameters.

Check warning on line 43 in src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs#L43 

Use the overloading mechanism instead of the optional parameters.

Check notice on line 53 in src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs#L53 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 54 in src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs#L54 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 75 in src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/ConsoleAdminRepl.cs#L75 

Add curly braces around the nested statement(s) in this 'foreach' block.

Check warning on line 34 in src/server/Mangos.Cluster.Admin/Commands/IAdminCommandHandler.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Admin/Commands/IAdminCommandHandler.cs#L34 

Use the overloading mechanism instead of the optional parameters.

Check warning on line 31 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L31 

Change this constant to a 'static' read-only property.

Check warning on line 34 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L34 

Change this constant to a 'static' read-only property.

Check warning on line 37 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L37 

Change this constant to a 'static' read-only property.

Check warning on line 40 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L40 

Change this constant to a 'static' read-only property.

Check warning on line 43 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L43 

Change this constant to a 'static' read-only property.

Check warning on line 46 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L46 

Change this constant to a 'static' read-only property.

Check warning on line 49 in src/server/Mangos.Cluster.Interop/ExitCodes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster.Interop/ExitCodes.cs#L49 

Change this constant to a 'static' read-only property.

Check warning on line 66 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L66 

Add a 'default' clause to this 'switch' statement.

Check notice on line 92 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L92 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 104 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L104 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 119 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L119 

Add curly braces around the nested statement(s) in this 'foreach' block.

Check notice on line 136 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L136 

Add curly braces around the nested statement(s) in this 'foreach' block.

Check warning on line 165 in src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedChatDeliverer.cs#L165 

Remove this unused method parameter 'env'.

Check notice on line 147 in src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs#L147 

Add curly braces around the nested statement(s) in this 'if' block.

Check warning on line 163 in src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs#L163 

Return 'Task' instead.

Check notice on line 168 in src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.Cluster/Federation/FederatedGroupInviter.cs#L168 

Add curly braces around the nested statement(s) in this 'if' block.
View more details on Codacy Production