Skip to content

[Maps] mangoszero map compatibility [Claude]#100

Draft
billy1arm wants to merge 3 commits into
mainfrom
claude/mangoszero-map-compatibility-HFhA2
Draft

[Maps] mangoszero map compatibility [Claude]#100
billy1arm wants to merge 3 commits into
mainfrom
claude/mangoszero-map-compatibility-HFhA2

Remove legacy map handling, implement VMap and MMap systems

7aa8380
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Mar 1, 2026 in 0s

258 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 258
           

Complexity increasing per file
==============================
- src/server/Mangos.World/Maps/WS_Maps.cs  14
- src/server/Mangos.World/Maps/VMap/StaticMapTree.cs  47
- src/server/Mangos.World/Maps/VMap/ModelInstance.cs  17
- src/server/Mangos.World/Maps/MMap/DtNavMesh.cs  48
- src/server/Mangos.World/Maps/MMapManager.cs  28
- src/server/Mangos.World/Maps/MapFileFormats.cs  18
- src/server/Mangos.World/Maps/VMap/Vector3.cs  22
- src/server/Mangos.World/Maps/MMap/DtNavMeshQuery.cs  33
- src/server/Mangos.World/Maps/GridMap.cs  90
- src/server/Mangos.World/Maps/VMap/BIH.cs  36
- src/server/Mangos.World/Maps/VMap/WorldModel.cs  77
- src/server/Mangos.World/Maps/MMap/PathInfo.cs  19
- src/server/Mangos.World/Maps/VMapManager.cs  20
         

Complexity decreasing per file
==============================
+ src/server/Mangos.World/Maps/WS_Maps.TMapTile.cs  -5
+ src/server/Mangos.World/WorldServer.cs  -2
         

Clones added
============
- src/server/Mangos.World/Maps/WS_Maps.cs  14
- src/server/Mangos.World/Maps/VMap/StaticMapTree.cs  4
- src/server/Mangos.World/Maps/MMapManager.cs  4
- src/server/Mangos.World/Maps/GridMap.cs  5
- src/server/Mangos.World/Maps/VMap/WorldModel.cs  2

See the complete overview on Codacy

Annotations

Check warning on line 41 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L41 

Change this constant to a 'static' read-only property.

Check warning on line 42 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L42 

Change this constant to a 'static' read-only property.

Check warning on line 44 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L44 

Change this constant to a 'static' read-only property.

Check warning on line 45 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L45 

Change this constant to a 'static' read-only property.

Check warning on line 47 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L47 

Change this constant to a 'static' read-only property.

Check warning on line 643 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L643 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 644 in src/server/Mangos.World/Maps/GridMap.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/GridMap.cs#L644 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 30 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L30 

Change this constant to a 'static' read-only property.

Check warning on line 42 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L42 

Implement 'IEquatable<T>' in value type 'DtPolyRef'.

Check warning on line 75 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L75 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 76 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L76 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 81 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L81 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 83 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L83 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 84 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L84 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 87 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L87 

Make this field 'private' and encapsulate it in a 'public' property.

Check notice on line 118 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L118 

Add curly braces around the nested statement(s) in this 'for' block.

Check warning on line 132 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L132 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 133 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L133 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 134 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L134 

Make this field 'private' and encapsulate it in a 'public' property.

Check warning on line 167 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L167 

Make 'Polys' private.

Check warning on line 168 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L168 

Make 'RawData' private.

Check notice on line 180 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L180 

Remove the array type; it is redundant.

Check notice on line 190 in src/server/Mangos.World/Maps/MMap/DtNavMesh.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMesh.cs#L190 

Add curly braces around the nested statement(s) in this 'if' block.

Check notice on line 36 in src/server/Mangos.World/Maps/MMap/DtNavMeshQuery.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMeshQuery.cs#L36 

Add curly braces around the nested statement(s) in this 'for' block.

Check warning on line 78 in src/server/Mangos.World/Maps/MMap/DtNavMeshQuery.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/server/Mangos.World/Maps/MMap/DtNavMeshQuery.cs#L78 

Consider refactoring this method in order to remove the need for this 'out' modifier.
View more details on Codacy Production