Repository navigation
Fix/interaction plot violin points - #838
Open
guillaume-vignal wants to merge 1 commit into
Open
guillaume-vignal wants to merge 1 commit into
guillaume-vignal wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #838 +/- ##
===========================================
+ Coverage 86.20% 86.21% +0.01%
===========================================
Files 115 115
Lines 11864 11872 +8
Branches 2161 2163 +2
===========================================
+ Hits 10227 10236 +9
- Misses 996 998 +2
+ Partials 641 638 -3
🚀 New features to boost your workflow:
|
| for trace in fig.data: | ||
| if trace.fill != "toself": | ||
| trace.customdata = interaction_customdata | ||
| trace_customdata = trace.customdata.tolist() |
Collaborator
There was a problem hiding this comment.
do we need a list here? if yes can you explain why? otherwise I don't think the whole loop is needed
Comment on lines
+151
to
+155
| color_column = col_name | ||
| if color_column == x_name: | ||
| color_column = f"{col_name}__color" | ||
| while color_column in (x_name, y_name, "__x_hover__"): | ||
| color_column += "_" |
Collaborator
There was a problem hiding this comment.
do you think this is really necessary? you could simply add a fixed internal column name such as __color__ (as it is already done for __x_hover__) inside data_df and labels:
color_column = "__color__"
data_df = pd.DataFrame({
x_name: x_series.values,
y_name: y_series.values,
color_column: col_values.values.flatten(),
"__x_hover__": x_values_hover.values.flatten(),
})
labels = {"__x_hover__": x_name, color_column: col_name}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #837
Before:

After:
