Repository navigation
Lint and format notebooks, notebook dependency group and NLP notebook outputs - #812
Merged
milton-minervino merged 5 commits intoOct 27, 2026
Merged
Conversation
The tutorials are rendered in the documentation, so they now follow the same ruff rules as the package, in CI and in the pre-commit hooks. - Stop excluding tutorial/ and notebooks from ruff; ignore docstring, import-position and assert rules in tutorials. - Run the ruff pre-commit hooks on notebooks. - Apply ruff's fixes (import sorting, trailing whitespace, unused and repeated imports) and formatting. Only code cell sources change; saved outputs are kept. - Fix the remaining findings by hand: display each attribute in the NLP overview instead of only the last one, drop a redundant IPython display import, and clear a list instead of rebinding it as a global.
An exact `uv sync` removed the Jupyter kernel from the environment, since no group declared it. Add a `notebook` group (included in `dev-all`) and document it in CONTRIBUTING.md and the NLP overview notebook, whose install cell now shows the PyPI command for users.
guerinclement
approved these changes
Oct 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #812 +/- ##
===========================================
- Coverage 86.09% 86.08% -0.01%
===========================================
Files 115 115
Lines 11825 11825
Branches 2158 2158
===========================================
- Hits 10181 10180 -1
- Misses 1008 1009 +1
Partials 636 636 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tutorials appear in the documentation, so they now follow the same ruff rules as the package.
Changes
tutorial/and notebooks are no longer excluded from ruff, in CI or in the pre-commit hooks. The docstring, import-position and assert rules are ignored for tutorials.notebookgroup: a notebook dependency group withipykernel, included indev-all. An exactuv syncremoved the Jupyter kernel because no group declared it. To run the tutorials:uv sync --group notebook, plus--extradependencies if needed (for examplereport,nlp).CONTRIBUTING.md: documents the notebook group.