Repository navigation
Use symbol precision for chart price labels - #418
Draft
ChristopherDownie wants to merge 1 commit into
Draft
ChristopherDownie wants to merge 1 commit into
ChristopherDownie wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
On EURUSD, the candle readout and Fibonacci price labels rounded
1.10228to1.10, making different prices look the same.Summary
Use the instrument’s tick size for both labels. Update the precision when metadata arrives or refreshes, and fall back to the existing formatting if the tick size is unavailable.
End-to-end verification
In the local Chrome playground, the same EURUSD candle and Fib level displayed
1.10before the patch and1.10228after it. Switching to GBPUSD and USDJPY used each pair’s precision once its metadata arrived.Checklist
npm run typecheck,npm run lint,npm test, andnpm run buildall passdocs/has been added / updated (for public interface or feature changes)CHANGELOG.mdhas an entry under[Unreleased](for user-visible changes)