Repository navigation
Status line action menu, symbol logo toggle, and hidden-chart eye - #101
Merged
Merged
Conversation
Right-clicking the status line opens an action menu with a checkable toggle per element (symbol logo, symbol name, market status, OHLC, bar change) plus hide/show for the chart's price series - the same switch as the object tree's eye. The symbol logo gets its own toggle in the settings dialog's Status line tab, and hiding the symbol name also hides the venue/timeframe meta beside it. The line now dresses like the indicator legend rows: hovering outlines it, and while the chart is hidden it dims, drops its OHLC and change readouts, and shows an eye button that brings the chart back. Segment visibility and the menu descriptors live in a pure model module with unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8f2c30fd-5151-4f49-9df6-60094aa4a686) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
candleVisiblerenderer feature as the object tree's eye. The click never opens the chart's own context menu.status-line.logo), mirrored across style-linked cells like the other parts. Hiding Symbol name now also hides the venue/timeframe meta beside it ("BTCUSDT · BINANCE · 1h" reads as one label).candleVisiblehas no change event.statusline-model.ts(mirroringcontext-menu-model.ts) with unit tests; CHANGELOG and user docs updated.Test plan
typecheck,lint,test(1442, incl. 8 new model tests),buildall greenNote
Low Risk
UI-only changes to the status line overlay and prefs shape; chart visibility uses the existing
candleVisiblerenderer feature with no auth or data-path changes.Overview
The in-chart status line gains a right-click menu with checkable toggles for each segment (symbol logo, name, market status, OHLC, bar change) plus Hide chart / Show chart, wired to the same
candleVisiblepath as the object tree. Part changes go through the cell host so style sync and persistence stay consistent with the settings dialog.A new
logosegment is exposed in chart settings (status-line.logo) and in saved status prefs; hiding symbol name also hides the venue/timeframe meta beside it.Legend-row behavior matches indicator rows: hover inset outline, 0.5 opacity when the price series is hidden, OHLC/change suppressed in that state, and an eye control to show the chart again. Visibility rules live in pure
statusline-model.ts(segmentVisibility,statuslineMenuItems) with unit tests; docs and the changelog describe the feature.Reviewed by Cursor Bugbot for commit ccb9530. Bugbot is set up for automated code reviews on this repo. Configure here.