Repository navigation
Emit no model for a run that never executed the script body - #30
Merged
Merged
Conversation
A run over zero bars (empty initial load: auth race, unresolved symbol, transient feed failure) never executes the declaration, so the mapped model fabricated defaults - title Indicator, overlay false - and the host finalized pane routing off them, stranding an overlay indicator in an empty sub pane. Such a run now emits nothing at all, from the static path and the live stream alike; the session re-runs when bars arrive and the first real model carries the executed declaration. Both engines share the rule through the runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0dbf5f9b-4ab4-48d8-996c-e7e7092605c8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indicator(...)/strategy(...)call — yetpineCtxToModelstill mapped it, fabricating default metadata (title: Indicator,overlay: false). Hosts finalized pane routing and the legend title off that fabricated model, permanently stranding anoverlay = trueindicator in an empty sub pane titled Indicator (the classic workspace-restore race).runPineStaticreturns a null model when the run context carries no executed declaration (newdeclarationExecutedhelper), and the live stream skips such ticks. The session re-runs when bars arrive, and that first real model carries the executed declaration. The rule lives in the sharedruntime, soPineEngineandPineWorkerEnginebehave identically; the worker still acksdoneso run bookkeeping balances.Companion PR
This is the root-cause half of a two-layer fix. LuxAlgo/Vela#105 adds the engine-agnostic orchestrator guard: an output-free model arriving while the chart still has no bars is deferred instead of finalizing pane routing, so no engine can strand an indicator this way. Either PR alone fixes the user-visible symptom for Pine; together each layer covers the other.
Tests
test/empty-run-suppression.test.ts: overlay + non-overlay empty-then-bars runs throughPineEngine(static and live stream) and through the real worker module driven over its message protocol; regression pins that an executed run keeps runtime-authoritative metadata (variableoverlay=arg);declarationExecutedshape cases; plus an end-to-end test through the built Vela + realPineEngine: placeholder stays on the price pane with the declared title while loading, recovers when data arrives. 6 of the new tests fail without the fix.