Remove sass source maps#41
Open
bronzehedwick wants to merge 1 commit into
Open
Conversation
Source maps are useful in development, but the source map pointer is added to production files in dist. The source map files themselves are (rightly) not included in the NPM package. This can cause an extra network request and an error. To solve, remove source maps from compiled SASS files.
Contributor
Author
|
I ran into this on a project, where Drupal omits an error on every page, as it tries to load a sourcemap file that doesn't exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source maps are useful in development, but the source map pointer is added to production files in dist. The source map files themselves are (rightly) not included in the NPM package. This can cause an extra network request and an error.
To solve, remove source maps from compiled SASS files.