Add .js extension to knex import - #3783
Merged
Merged
Conversation
kathyavini
requested review from
Duncan-Brain and
antsgar
and removed request for
a team
May 27, 2025 16:46
Duncan-Brain
approved these changes
May 27, 2025
Collaborator
|
Heres the other pr: #3784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the last merge, this old import line in
mock.factories.jsfile crashed the backend container as follows:In PR #3755 there is a mocking function residing in a file which imports the file above. This mocking function is used in a service file that is called by a controller. This chain is the first time that
mock.factories.jshas been called from the actualserver.jsand not just by the jest testing environment (presumably more forgiving about imports), causing this crash.This PR adds the extension to fix the crash, but @Duncan-Brain will be opening a PR to also fix the import chain to avoid importing from
/testsentirely 🙏 Right now we don't exclude/testsfrom the backend docker container but that's more on oversight than anything else; ideally all server-called code should reside in/srcand only that should be part of the production container.Jira link: None
Type of change
How Has This Been Tested?
Did not test; please merge to test on beta.
Checklist:
pnpm i18nto help with this)