-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: correct statements that no longer match the source (Code Notes, G-code, HAL) #4349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
5ac93bb
a8fb59b
f587664
8ff284d
2fb549b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1109,9 +1109,15 @@ M2 (end program) | |
| It is an error if: | ||
|
|
||
| * All axis words are omitted. | ||
| * The spindle is not turning when this command is executed. | ||
| * The requested linear motion exceeds machine velocity limits | ||
| due to the spindle speed. | ||
| * No K word is given. | ||
| * An F word is given (the feed follows from K and the spindle speed). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Additions check out (interp_check.cc:376 and :377). Could the deleted velocity-limit line stay as a NOTE though? It is real behaviour when pitch times RPM exceeds the axis limit, and it was the only mention in the manual.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, and it is worse than one line: the same sentence was at 1113 and at 1179, and the patch removed both, so it left the manual altogether rather than one of the two places. Restored as a NOTE in both. One caveat, because I have not verified the mechanism: there is no interpreter check and no error message for that case, so if it is real it is a silent clamp in the planner. The NOTE therefore says only that the program is not rejected, rather than asserting what happens instead. |
||
| * The selected spindle is not commanded to turn (M3 or M4 active) when | ||
| this command is executed. | ||
|
|
||
| [NOTE] | ||
| The pitch and the spindle speed together set the axis feed. If they ask for | ||
| more than the machine can deliver, the program is not rejected: there is no | ||
| interpreter check and no error message for that case. | ||
|
|
||
| [[gcode:g33.1]] | ||
| == G33.1 Rigid Tapping(((G33.1 Rigid Tapping))) | ||
|
|
@@ -1123,6 +1129,7 @@ G33.1 X- Y- Z- K- I- $- | |
|
|
||
| * 'K' - distance per revolution | ||
| * 'I' - optional spindle speed multiplier for faster return move | ||
| (values less than 1 are treated as 1) | ||
| * '$' - optional spindle selector | ||
|
|
||
| [WARNING] | ||
|
|
@@ -1175,9 +1182,15 @@ M2 (end program) | |
| It is an error if: | ||
|
|
||
| * All axis words are omitted. | ||
| * The spindle is not turning when this command is executed | ||
| * The requested linear motion exceeds machine velocity limits | ||
| due to the spindle speed | ||
| * No K word is given. | ||
| * An F word is given (the feed follows from K and the spindle speed). | ||
| * The selected spindle is not commanded to turn (M3 or M4 active) when | ||
| this command is executed. | ||
|
|
||
| [NOTE] | ||
| The pitch and the spindle speed together set the axis feed. If they ask for | ||
| more than the machine can deliver, the program is not rejected: there is no | ||
| interpreter check and no error message for that case. | ||
|
|
||
| [[gcode:g38]] | ||
| == G38._n_ Straight Probe(((G38.n Probe))) | ||
|
|
@@ -1677,6 +1690,11 @@ G64 <P- <Q->> | |
|
|
||
| It is a good idea to include a path control specification in the preamble of each G-code file. | ||
|
|
||
| It is an error if: | ||
|
|
||
| * The path control mode is changed (G61, G61.1 or G64) while cutter | ||
| radius compensation is active. | ||
|
|
||
| .G64 P- Q- Example Line | ||
| [source,ngc] | ||
| ---- | ||
|
|
@@ -2720,7 +2738,8 @@ G96 <D-> S- <$-> (Constant Surface Speed Mode) | |
| G97 S- <$-> (RPM Mode) | ||
| ---- | ||
|
|
||
| . 'D' - maximum rotation speed (RPM), optional | ||
| . 'D' - maximum rotation speed (RPM), optional. Without D the spindle | ||
| speed in CSS mode is not limited by the interpreter. | ||
| . 'S' - spindle speed | ||
| . '$' - the spindle of which the speed will be varied, optional. | ||
|
|
||
|
|
@@ -2747,7 +2766,6 @@ G96 D2500 S250 (set CSS with a max rpm of 2500 and a surface speed of 250) | |
| It is an error if: | ||
|
|
||
| * S is not specified with G96 | ||
| * A feed move is specified in G96 mode while the spindle is not turning | ||
|
|
||
| [[gcode:g98-g99]] | ||
| == G98, G99 Canned Cycle Return Level(((G98, G99 Canned Cycle Return))) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is planner behaviour rather than PAUSE-command behaviour; two sentences plus the synchronized-motion exception would cover what a Code Notes reader needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. Cut to two sentences plus the synchronized-motion exception.