Skip to content

Fix brainstorm invalid eval triage #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
El-Fitz merged 5 commits into from
Jun 17, 2026
Merged

Fix brainstorm invalid eval triage #46

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc805a7
fix: harden brainstorm evaluation score parsing
El-Fitz Jun 11, 2026
ca0242a
docs: add L3 parser validation runbook
El-Fitz Jun 12, 2026
1ce2797
fix: capture invalid brainstorm eval responses
El-Fitz Jun 12, 2026
7243d0d
test: verify invalid eval preview artifacts
El-Fitz Jun 14, 2026
5d51dce
fix: handle labeled brainstorm score text
El-Fitz Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/refinery_cli/src/commands/brainstorm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ struct ProviderFailureOutput {
#[serde(skip_serializing_if = "Option::is_none")]
target_model_id: Option<String>,
message: String,
#[serde(skip_serializing_if = "Option::is_none")]
response_preview: Option<String>,
}

#[derive(Serialize)]
Expand Down Expand Up @@ -385,6 +387,7 @@ fn provider_failure_output(failure: &BrainstormProviderFailure) -> ProviderFailu
model_id: failure.model_id.to_string(),
target_model_id: failure.target_model_id.as_ref().map(ToString::to_string),
message: failure.message.clone(),
response_preview: failure.response_preview.clone(),
}
}

Expand Down
Loading
Loading