Skip to content

GH Issue 1619: Fix cross-container handling in assay run QC history and QC state update page - #8217

Merged
cnathe merged 3 commits into
developfrom
fb_qc_cross_container_1619
Oct 23, 2026
Merged

cnathe merged 3 commits into
developfrom
fb_qc_cross_container_1619

Conversation

@cnathe

@cnathe cnathe commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

This PR makes assay run QC history show QC state changes made from a folder other than the run's own, and makes the QC state update page work for runs in another folder. QC audit events were stamped with the request's container, so changes made from the project-level app never appeared in the run's history. Separately, the server-rendered QC state page looked runs up in the current folder only. Issue: GH Issue 1619

Related Pull Requests

Changes

  • QC state audit events are stamped with the run's container going forward.
  • Both QC history views (the app's run details page and the LKS QC State page) include events stamped in the run's folder or any parent folder or child folders the user can read, so existing mis-stamped events now show without modifying audit rows.
  • The QC history container scope is fixed server-side, so a container filter URL parameter can no longer widen the elevated audit query, and the run permission check uses assay read permission.
  • The QC state update page uses the runs the action already validated, so it shows the current state, QC state options, and comment requirement for runs in other folders.

- Stamp QC audit events with the run's container
- include events from the run's ancestor folders the user can read in both QC history views
@cnathe cnathe self-assigned this Oct 22, 2026
@cnathe
cnathe requested a review from labkey-klum October 22, 2026 15:07
… view, include run's container children, test updates
settings.setBaseSort(new Sort("-Created"));

QueryView view = schema.createView(getViewContext(), settings, errors);
view.setContainerFilter(getRunQCHistoryContainerFilter(run, getUser()));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution.

@cnathe
cnathe merged commit cfe0bf8 into develop Oct 23, 2026
12 checks passed
@cnathe
cnathe deleted the fb_qc_cross_container_1619 branch October 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants