Repository navigation
GH Issue 1619: Fix cross-container handling in assay run QC history and QC state update page - #8217
Merged
Merged
Conversation
- Stamp QC audit events with the run's container - include events from the run's ancestor folders the user can read in both QC history views
… view, include run's container children, test updates
labkey-klum
reviewed
Oct 22, 2026
| settings.setBaseSort(new Sort("-Created")); | ||
|
|
||
| QueryView view = schema.createView(getViewContext(), settings, errors); | ||
| view.setContainerFilter(getRunQCHistoryContainerFilter(run, getUser())); |
Contributor
There was a problem hiding this comment.
This is a nice solution.
labkey-klum
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR makes assay run QC history show QC state changes made from a folder other than the run's own, and makes the QC state update page work for runs in another folder. QC audit events were stamped with the request's container, so changes made from the project-level app never appeared in the run's history. Separately, the server-rendered QC state page looked runs up in the current folder only. Issue: GH Issue 1619
Related Pull Requests
Changes