Repository navigation
Check external data sources in a separate health check category - #8198
Merged
Merged
Conversation
Default health check failures take the server out of rotation, which can't fix an external database, so external data sources now report under the externalDataSources category.
Contributor
Author
|
Example responses for a site admin, with the LabKey database Before: {
"default": {
"healthy": false,
"details": {
"database": { "healthy": false, "details": { "labkey": true, "warehouse": false } }
}
},
"healthy": false
}After: {
"default": {
"healthy": true,
"details": {
"database": { "healthy": true, "details": { "labkey": true } }
}
},
"healthy": true
}After: {
"externalDataSources": {
"healthy": false,
"details": {
"database": { "healthy": false, "details": { "warehouse": false } }
}
},
"healthy": false
}Compatibility: the |
labkey-jeckels
requested review from
labkey-gokhano,
labkey-jony,
labkey-martyp,
labkey-matthewb and
labkey-willm
October 17, 2026 20:25
The default check no longer connects to external data sources, and the externalDataSources category reports ones that failed to connect. Adds HealthCheckTestCase.
labkey-adam
approved these changes
Oct 18, 2026
labkey-martyp
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The default health check should fail only when the LabKey database is unreachable, while external data sources stay visible through a separate category. Today an unreachable external data source makes the default check return 503, so load balancers and probes pull or restart a server that is otherwise working, and neither action can fix an external database.
Changes
externalDataSourcescategory, for monitoring that wants an explicit signal; it also reports data sources that failed to connect. Their connection failure/reconnect logging now happens only when that category (orall) is polled.categories=allsee external data source failures as before.Tasks