Repository navigation
Delete large number of job samples takes a long time and triggers large-collection warning - #8195
Merged
Merged
Conversation
…ge-collection warning
…ge-collection warning
labkey-nicka
self-requested a review
October 19, 2026 19:14
labkey-nicka
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Makes the sample operation confirmation scale to very large selections. Confirming an operation loaded a full sample object for every selected row, so a user who selected tens of thousands of samples waited a long time and the server logged a large-collection warning. The confirmation needs only a few facts about each sample — where it lives, its status and its sample type — so nearly everything it loaded went unused. The companion change in limsModules does the same for the removal that follows.
Related Pull Requests
Changes