Repository navigation
Grid: suggest filters from grid search - #8191
Merged
Merged
Conversation
This was referenced Oct 16, 2026
labkey-nicka
force-pushed
the
fb_grid_search
branch
from
October 16, 2026 18:20
db37691 to
ec5a43c
Compare
XingY
reviewed
Oct 19, 2026
|
|
||
| private static @Nullable List<String> getValidValues(ColumnInfo column) | ||
| { | ||
| IPropertyValidator validator = PropertyService.get().getValidatorForColumn(column, PropertyValidatorType.TextChoice); |
Contributor
There was a problem hiding this comment.
If a field is text choice or multi choice, but didn't get to define valid values yet, will validator be null?
labkey-nicka
force-pushed
the
fb_grid_search
branch
from
October 19, 2026 22:29
ec5a43c to
3fd9a78
Compare
XingY
approved these changes
Oct 21, 2026
labkey-nicka
force-pushed
the
fb_grid_search
branch
2 times, most recently
from
October 23, 2026 23:25
23048bd to
b82c6d9
Compare
labkey-nicka
force-pushed
the
fb_grid_search
branch
from
October 25, 2026 03:08
b82c6d9 to
d70e914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This updates the grid search to offer and apply suggested filters based on search term.
Related Pull Requests
Changes