Repository navigation
SqlFragment no longer implements CharSequence - #8185
Merged
Merged
Conversation
These result in some odd and probably unexpected behavior.
Some code-coverage improvements in Study test
labkey-adam
approved these changes
Oct 15, 2026
| .append(" P.").append(cohortFilter.getType() == CohortFilter.Type.PTID_CURRENT ? "CurrentCohortId" : "InitialCohortId") | ||
| .append(" = ?\n").append(qcStates != null ? "AND " + qcStates.getStateInClause(DatasetTableImpl.QCSTATE_ID_COLNAME) + "\n" : ""); | ||
| sql.add(cohortFilter.getCohortId()); | ||
| .append(" = ").appendValue(cohortFilter.getCohortId()).append("\n"); |
Contributor
There was a problem hiding this comment.
Why not keep the parameter marker for cohortFilter.getCohortId()?
Contributor
Author
There was a problem hiding this comment.
This is just style. I occasionally see .add() calls that get pretty far from the parameter marker. I think it's nice to not have to match them up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We "disabled" auto-convert from SQLFragment to String by poisoning .toString(). However, SQLFragment implements CharSequence. That enables some unexpected/ambiguous usages. For instance
a ? SQLFragment() : String)unexpectedly casts to CharSequence which may not be correct.Related Pull Requests
Changes