Skip to content

GH Issue 1640: Use a new key for provided amounts and flag old values in the sample timeline audit log - #8164

Merged
cnathe merged 8 commits into
release26.7-SNAPSHOTfrom
26.7_fb_providedValuesDisplay
Oct 12, 2026
Merged

cnathe merged 8 commits into
release26.7-SNAPSHOTfrom
26.7_fb_providedValuesDisplay

Conversation

@cnathe

@cnathe cnathe commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

GH Issue 1640: new user-entered amounts are recorded in the audit metadata as :::user_provided:::Amount, and the sample timeline tooltip reads only that key. Old :::provided:::Amount values, which may be wrong from before the #8144 fix, are hidden from the timeline. In both the LabKey Server grid and the app grid, they're flagged with a warning and an explanation instead. Existing audit records aren't changed.

Related Pull Requests

Changes

  • Record user-provided amounts in sample timeline audit metadata under a new :::user_provided:::Amount key
  • Highlight Sample Timeline audit Metadata values that contain the old key, with a hover message saying the value may be inaccurate
  • Unit test for the old-key check, and the large-import audit test updated for the new key

@cnathe cnathe self-assigned this Oct 12, 2026
@cnathe
cnathe requested review from XingY and labkey-susanh October 12, 2026 14:40
Comment thread api/src/org/labkey/api/audit/AuditHandler.java

@XingY XingY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should SampleTimelineAuditEvent EXCLUDED_DETAIL_FIELDS be updated to include both the old and new keys?

@cnathe

cnathe commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Should SampleTimelineAuditEvent EXCLUDED_DETAIL_FIELDS be updated to include both the old and new keys?

I don't believe (and claude confirmed) that the new key is needed in this set since it only applies to the old/new record map. The new key is only ever used in the event metadata column value.

@cnathe
cnathe requested a review from labkey-susanh October 12, 2026 19:15
@XingY

XingY commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Should SampleTimelineAuditEvent EXCLUDED_DETAIL_FIELDS be updated to include both the old and new keys?

I don't believe (and claude confirmed) that the new key is needed in this set since it only applies to the old/new record map. The new key is only ever used in the event metadata column value.

You are right, the new field never reached old/new record map.

@XingY
XingY self-requested a review October 12, 2026 19:17
@cnathe
cnathe merged commit 3b26982 into release26.7-SNAPSHOT Oct 12, 2026
11 of 16 checks passed
@cnathe
cnathe deleted the 26.7_fb_providedValuesDisplay branch October 12, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants