Repository navigation
GH Issue 1640: Use a new key for provided amounts and flag old values in the sample timeline audit log - #8164
Conversation
…ies use :::user_provided:::Amount.
…fb_providedValuesDisplay
XingY
left a comment
There was a problem hiding this comment.
Should SampleTimelineAuditEvent EXCLUDED_DETAIL_FIELDS be updated to include both the old and new keys?
I don't believe (and claude confirmed) that the new key is needed in this set since it only applies to the old/new record map. The new key is only ever used in the event metadata column value. |
You are right, the new field never reached old/new record map. |
Rationale
GH Issue 1640: new user-entered amounts are recorded in the audit metadata as
:::user_provided:::Amount, and the sample timeline tooltip reads only that key. Old:::provided:::Amountvalues, which may be wrong from before the #8144 fix, are hidden from the timeline. In both the LabKey Server grid and the app grid, they're flagged with a warning and an explanation instead. Existing audit records aren't changed.Related Pull Requests
Changes
:::user_provided:::Amountkey