[labkey-tchad]

Rationale

SequenceVisitManager.getVisitSummarySql doesn't add parameter values for all of the parameters it adds to the query generated for a DATA_COLLECTION cohort filter.

This was found by the crawler doing parameter injection. I'm not sure what the expected path is to invoke this code but it appears to have had this problem since sometime in 2019.

org.springframework.dao.DataIntegrityViolationException: ExecutingSelector; No value specified for parameter 3.
	at org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate(SQLStateSQLExceptionTranslator.java:118) ~[spring-jdbc-6.2.10.jar:6.2.10]
	at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:107) ~[spring-jdbc-6.2.10.jar:6.2.10]
	at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:116) ~[spring-jdbc-6.2.10.jar:6.2.10]
	at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:116) ~[spring-jdbc-6.2.10.jar:6.2.10]
	at org.labkey.api.data.ExceptionFramework$1.translate(ExceptionFramework.java:43) ~[api-25.10-SNAPSHOT.jar:?]
	at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleSqlException(SqlExecutingSelector.java:553) ~[api-25.10-SNAPSHOT.jar:?]
	at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleResultSet(SqlExecutingSelector.java:457) ~[api-25.10-SNAPSHOT.jar:?]
	at org.labkey.api.data.SqlExecutingSelector.getResultSet(SqlExecutingSelector.java:193) ~[api-25.10-SNAPSHOT.jar:?]
	at org.labkey.api.data.SqlExecutingSelector.getResultSet(SqlExecutingSelector.java:233) ~[api-25.10-SNAPSHOT.jar:?]
	at org.labkey.study.visitmanager.VisitManager.getVisitSummary(VisitManager.java:231) ~[study-25.10-SNAPSHOT.jar:?]
	at org.labkey.study.controllers.StudyController$OverviewAction.getView(StudyController.java:720) ~[study-25.10-SNAPSHOT.jar:?]
	at org.labkey.study.controllers.StudyController$OverviewAction.getView(StudyController.java:694) ~[study-25.10-SNAPSHOT.jar:?]

Related Pull Requests

• 7136eff0

Changes

• Add missing query parameter value to visit summary query

[labkey-matthewb]

I would consider moving the add() closer to the "?", or even migrating to .appendValue(container)