Skip to content

Add PostgreSQL version of onprc_ehr-26.004-26.005 upgrade script - #1912

Merged
labkey-bpatel merged 2 commits into
release26.3-SNAPSHOTfrom
26.3_fb_tb_historical_pg_script
Oct 2, 2026
Merged

labkey-bpatel merged 2 commits into
release26.3-SNAPSHOTfrom
26.3_fb_tb_historical_pg_script

Conversation

@labkey-bpatel

Copy link
Copy Markdown
Contributor

Rationale

Adds the missing PostgreSQL upgrade script for the TB Test historical process from #1886, which fixes the SchemaXMLTestCase failure for onprc_ehr on PostgreSQL.

Related Pull Requests

Changes

  • Create the four TB Test historical tables on PostgreSQL
  • Port p_Create_TB_Observation_Historical_records to plpgsql

@labkey-adam labkey-adam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this script "missed" the initial module bump, I suggest naming it onprc_ehr-26.005-26.006.sql and bumping the module to 26.006. This ensures it actually runs on all the PostgreSQL deployments.

@labkey-bpatel

Copy link
Copy Markdown
Contributor Author

Since this script "missed" the initial module bump, I suggest naming it onprc_ehr-26.005-26.006.sql and bumping the module to 26.006. This ensures it actually runs on all the PostgreSQL deployments.

Done!

@labkey-adam labkey-adam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that the SQL Server tables defined no primary keys

@labkey-bpatel
labkey-bpatel merged commit a2eeaa3 into release26.3-SNAPSHOT Oct 2, 2026
7 of 8 checks passed
@labkey-bpatel
labkey-bpatel deleted the 26.3_fb_tb_historical_pg_script branch October 2, 2026 17:15
@labkey-bpatel

Copy link
Copy Markdown
Contributor Author

Just noting that the SQL Server tables defined no primary keys

Good observation! Since rowid is an IDENTITY col on SQL Server tables without a PK, it shouldn't be an issue during migration. However, we'll bring it to the client's attention during weekly meeting next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants