No stdlib - #681
Closed
patrick-nicodemus wants to merge 3 commits into
Closed
Conversation
Contributor
|
The string thing is a hack to work around a limitation in dune. I'll keep the pr open waiting for that to be fixed, there is a pr that will eventually be merged. |
Contributor
|
Note that this may be related to rocq-prover/rocq#19530 |
Contributor
|
@patrick-nicodemus #767 may help here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes some changes throughout the build script to replace the automatic importing of the Prelude everywhere with an explicit, qualified importation, as part of an attempt to track down why
Require Elpihas the effect ofRequire Prelude.After changing the dune files it seems clear that we cannot remove the dependence on the
Preludewithout removing the dependence on theStringmodule, so I will hold off on doing anything further until someone can suggest a workaround to usingStringin the build script.