Allow Ctrl-Drag Copying Tracks via TrackGrip - #8495
Merged
Merged
Conversation
rubiefawn
added
bug
gui
master branch
rubiefawn
approved these changes
Aug 3, 2026
rubiefawn
left a comment
rubiefawn
left a comment
Contributor
There was a problem hiding this comment.
Code looks good, did some testing on the Windows build.
yohannd1
reviewed
Aug 3, 2026
yohannd1
left a comment
yohannd1
left a comment
Contributor
There was a problem hiding this comment.
Tested it on Linux, works fine for me. Code wise I don't think I can say much but it looks alright, except for these two nitpicks:
Member
Author
|
Thanks for testing! If there are no objections, I may merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address #7766 by making it possible to ctrl-drag on the TrackGrip (the patterned part on the very left edge of a track), to copy them, rather than having to carefully aim your mouse around the large settings/mute/solo buttons to copy a track.
2026-08-02.19-07-07.mp4
I made the constructor of
TrackGriptake in theTrackViewrather than theTrack, since it is necessary to generate the drag preview image of the track. I think that is reasonable, sinceTrackGripis in the GUI.