-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(#6716): ✨ added effect categories #8493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clemetayer
wants to merge
10
commits into
LMMS:master
Choose a base branch
from
clemetayer:#6716_effects_groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7145167
feat(#6716): 🚧 added effect types
f376530
Revert "feat(#6716): 🚧 added effect types"
54bb938
feat(#6716): 🚧 added an effect for every category
b408aff
feat(#6716): ✨ added Categories for LADSPA effects
2827fa6
feat(#6716): ✨ Added an effect category filter
67ddde7
fix(#6716): 🐛 fixed an issue when selection "all" as an effect filter…
5200b28
chore(#6716): 🩹 changed the structure to respect coding conventions
78aa6ad
chore(#6716): 🩹 fixed style issues
7decb8a
refactor(#6716): ♻️ fixed more style issues and changed the effect ca…
97a537d
chore(#6716): 🌐 added translation keys for each effect
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||||||||
| /* | ||||||||||
| * EffectCategory - Associates an effect to a category (for grouping/filtering afterwards) | ||||||||||
| * | ||||||||||
| * This file is part of LMMS - https://lmms.io | ||||||||||
| * | ||||||||||
| * This program is free software; you can redistribute it and/or | ||||||||||
| * modify it under the terms of the GNU General Public | ||||||||||
| * License as published by the Free Software Foundation; either | ||||||||||
| * version 2 of the License, or (at your option) any later version. | ||||||||||
| * | ||||||||||
| * This program is distributed in the hope that it will be useful, | ||||||||||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||||||||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||||||||||
| * General Public License for more details. | ||||||||||
| * | ||||||||||
| * You should have received a copy of the GNU General Public | ||||||||||
| * License along with this program (see COPYING); if not, write to the | ||||||||||
| * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, | ||||||||||
| * Boston, MA 02110-1301 USA. | ||||||||||
| * | ||||||||||
| */ | ||||||||||
|
|
||||||||||
| #ifndef LMMS_EFFECT_CATEGORY_H | ||||||||||
| #define LMMS_EFFECT_CATEGORY_H | ||||||||||
|
|
||||||||||
| #include <qlabel.h> | ||||||||||
| #include <qlist.h> | ||||||||||
| #include <qobject.h> | ||||||||||
|
|
||||||||||
| #include "lmms_export.h" | ||||||||||
| namespace lmms | ||||||||||
| { | ||||||||||
|
|
||||||||||
| class LMMS_EXPORT EffectCategory | ||||||||||
| { | ||||||||||
| public: | ||||||||||
| static EffectCategory* instance(); | ||||||||||
| QString getCategoryName(QString effectName); | ||||||||||
| QStringList* getCategories(); | ||||||||||
| private: | ||||||||||
| static std::unique_ptr<EffectCategory> s_instance; | ||||||||||
| QStringList* m_categories; | ||||||||||
| QStringList* getCategoriesFromMap(std::map<QString,QString> map); | ||||||||||
| }; | ||||||||||
|
|
||||||||||
| // Short-hand function | ||||||||||
| LMMS_EXPORT EffectCategory* getEffectCategory(); | ||||||||||
| } // namespace lmms | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| #endif // LMMS_EFFECT_CATEGORY_H | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.