This repository was archived by the owner on Feb 19, 2021. It is now read-only.
Fixes - #40
Open
ItsMeLeeson wants to merge 4 commits into
Open
Conversation
SongInfo.cs - Uses new web socket addresses for JPOP and KPOP Fixes missing song title, album, and artist(s) from being displayed Fixes Discord rich presence WebStreamPlayer.cs - Change catch exception object to catch any type Fixes new songs not playing after current one finishes
|
Hi, just wanna let you know that this repo hasn't been maintained in a long time and I doubt it will be in the future, so the chances of a PR actually being reviewed/merged are low. I'm no dev/member of the Listen.moe Organization though, just a community member. The player that does get maintained is located at https://github.com/LISTEN-moe/desktop-app, although that one is based on Electron. If you'd like, you can have a look there. If you don't like Electron, you could maybe try to maintain a private fork of this C# player and update it to keep working properly. |
Author
|
#39 added |
Contributor
|
I would actually merge and publish this, BUT, in your last commit you mixed spaces and tabs, if you could correct that that'd be nice. |
Oops I'll blame Visual Studio
Author
|
Sorry about that fixed it now |
Use new music link url so clicking an album cover doesn't lead to an invalid page. For albums without a cover image the missing image will be used. This is so that users can still click the cover to be taken to the listen.moe album entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SongInfo.cs - Uses new web socket addresses for JPOP and KPOP
Fixes missing song title, album, and artist(s) from being displayed
Fixes Discord rich presence
WebStreamPlayer.cs - Change catch exception object to catch any type
Fixes new songs not playing after current one finishes