fix: omit timewarp from /state when inactive, matching real device - #13
Open
MrInterBugs wants to merge 1 commit into
Open
fix: omit timewarp from /state when inactive, matching real device#13MrInterBugs wants to merge 1 commit into
MrInterBugs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on my plugin for the device I have noticed the simulator is incorrect for a few different behaviours.
Changes
timewarpomitted from/statewhen inactiveOn the real device, the
timewarpkey is absent from the/stateresponse when time-lapse mode is off. The simulator was always includingtimewarp: 0, which does not match this behaviour.