Skip to content

Unfillable quotes via 0-liquidity pools #1720

Description

@josh-davis-vicinft

Example here: https://kyberswap.com/swap/polygon/usdt-to-fire

At the time of this writing, if you enter in 1 USDT for the input amount, it tells you that you will get approx 0.8 FIRE worth $1.17 as output. The problem is the trade is being routed through the UniSwap V3 pool at 0x496b7c93f87b72a3aa151460a97b12d9f018ac84 which has a liquidity value of 0 and only contains a tiny fraction of the promised amount of FIRE, and you get the expected error if you actually try to execute the swap.

If you reverse the trade and put 0.8 FIRE as the input amount, it routes though the correct UniSwap V3 pool at 0x60ea32a35f64628328f578c872dd6c6d81626aba, and you are able to execute the swap.

Can KyberSwap be made to skip over pools that don't have the liquidity required to fill a leg of the trade?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions