Repository navigation
Allow longer initiative effect names - #1763
Merged
Kruptein merged 8 commits intoFeb 5, 2026
Merged
Conversation
rexy712
marked this pull request as ready for review
January 28, 2026 20:39
Kruptein
requested changes
Feb 1, 2026
Kruptein
left a comment
Owner
There was a problem hiding this comment.
These are almost all nitpick/style changes
Kruptein
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the input element for initiative effect names with a textarea and also increases the width of the effect list. This allows longer names to be used in the textbox, and even if the name is too long, the text will wrap.
Code is not in a fully cleaned up state as the known issues currently prevent this from being completed.Known Issues: The textareas for the names of effects that span multiple lines do not automatically resize to fit the text when first loading the initiative tracker. Once a single character is typed, the textarea fits to the text as expected. I have no idea how to fix this.Edit
The issue of initial resizing has been fixed by adding a prop 'visible' to the ResizingTextArea component. Passing a value to this prop allows it to have a pseudo callback for when the component becomes visible and make the textbox resize at that point.
This now also accounts for when the text is changed from outside the ResizingTextArea component, resizing to fit the new content.
I've also added a separator line between effects since they now have variable heights. This makes it easier to tell where one ends and the next begins.
Fixes #1766