Skip to content

Fix note searchbar border not visible in firefox - #1752

Merged
Kruptein merged 2 commits into
Kruptein:devfrom
rexy712:note-searchbar-visual-fix
Jan 26, 2026
Merged

Kruptein merged 2 commits into
Kruptein:devfrom
rexy712:note-searchbar-visual-fix

Conversation

@rexy712

@rexy712 rexy712 commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

In firefox, the input element of the note list search bar was overlapping the border of the encapsulating #search-bar div.
This PR decreases the input's padding to fix this.
Before:
Screenshot_20260125_092556

After:
Screenshot_20260125_092609

@Kruptein

Kruptein commented Jan 26, 2026 •

Copy link
Copy Markdown
Owner

odd, this doesn't actually happen to me on firefox

image

I'm not against changing the padding, but it does feel like we're adjusting the wrong thing to actually fix the issue properly.

@Kruptein

Kruptein commented Jan 26, 2026 •

Copy link
Copy Markdown
Owner

removing the padding and adding height: 100% should also fix it I believe and actually make it 'correct'. (might have to add height: 100% to the input's parent as well.

@rexy712

rexy712 commented Jan 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Changing the height has no effect it seems. I've looked at it a bit and it's actually not the height but the font-size and font-family that's the problem. Changing the height for both the input and parent works, I must have skipped over the last part of your message when first reading. I'll still leave the rest of the original message here.

This is an issue I've had a couple of places before. For some reason Firefox and Chromium use different fonts in some places throughout PA. When I was making the initiative reskin, I believe I had to specify the font at some point because each browser used a different font if I didn't. I'm not enough of a web developer to say why this is the case though. I don't want to open an issue for this since it's probably something wrong with how I've got by browser/system configured.

Changing the font-family in firefox to match chromium's, the outline is still slightly overlapped along the bottom.

image

Changing the font-size to 1.15em in addition to changing the font-family fixes this for me.

@rexy712

rexy712 commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Firefox reports this for font-family on the input element:
image

Chromium reports this for font-family:
image

@rexy712
rexy712 marked this pull request as draft January 26, 2026 18:37
@rexy712
rexy712 marked this pull request as ready for review January 26, 2026 18:48
@rexy712
rexy712 force-pushed the note-searchbar-visual-fix branch from 00ba2c3 to 10523b8 Compare January 26, 2026 18:50
@Kruptein

Copy link
Copy Markdown
Owner

If you've noticed this before, we probably should properly fix the use of font(s) in PA to be uniform.
But that's for a different PR.

@Kruptein
Kruptein merged commit ae9cad3 into Kruptein:dev Jan 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants