Repository navigation
bug(Initiative) Fix initiative toggle vision lock interaction - #1750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initiative settings have a setting to auto modify the vision shown to only the active token.
This setting only activates when the initiative toggle function is used in the toolbar. When deactivating initiative, it's supposed to restore the vision-tool state to what it was before initiative started 1. This was only properly working if a vision-tool filter was in effect.
In most cases no active filter is in effect (i.e. all vision is shown) and deactivating initiative would not properly restore this.
Additionally the vision reset logic was running at all times when deactivating initiative, while it should only trigger when the vision lock initiative setting is turned on.
Footnotes
The set of active vision filters before initiative starts is only remembered during the session currently, if initiative is deactivated in a later session, it will always fall back to the full vision setup. ↩