Group Address and Group Attribute fixes and enhancements#118
Open
guymaness2 wants to merge 11 commits into
Open
Group Address and Group Attribute fixes and enhancements#118guymaness2 wants to merge 11 commits into
guymaness2 wants to merge 11 commits into
Conversation
nateh777
reviewed
Jul 2, 2026
guymaness2
commented
Jul 2, 2026
guymaness2
commented
Jul 2, 2026
guymaness2
commented
Jul 2, 2026
guymaness2
commented
Jul 2, 2026
Co-authored-by: Nate H <nateh777@users.noreply.github.com>
nateh777
reviewed
Jul 9, 2026
| var person = this.PersonDict.GetValueOrNull( string.Format( "{0}^{1}", this.ImportInstanceFKPrefix, groupAddressCsv.GroupMemberPersonId ) ); | ||
| if ( person != null ) | ||
| { | ||
| var groupMemberAddressTypeEnum = groupAddressCsv.IsValidGroupMemberAddressType ? groupAddressCsv.GroupMemberAddressTypeEnum : groupAddressCsv.AddressTypeEnum; |
Member
There was a problem hiding this comment.
Suggested change
| var groupMemberAddressTypeEnum = groupAddressCsv.IsValidGroupMemberAddressType ? groupAddressCsv.GroupMemberAddressTypeEnum : groupAddressCsv.AddressTypeEnum; | |
| var groupMemberAddressTypeEnum = groupAddressCsv.GroupMemberAddressTypeEnum; |
nateh777
reviewed
Jul 9, 2026
| } | ||
| if ( missingGroupTypeLocationTypes.Count > 0 ) | ||
| { | ||
| rockContext.GroupTypeLocationTypes.AddRange( missingGroupTypeLocationTypes ); |
Member
There was a problem hiding this comment.
should we be doing addrange/savechanges for this or a bulkinsert?
nateh777
reviewed
Jul 9, 2026
Comment on lines
+97
to
+98
| } | ||
| public bool IsValidGroupMemberAddressType |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| public bool IsValidGroupMemberAddressType | |
| } | |
| public bool IsValidGroupMemberAddressType |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the change add or fix?
Various bug fixes and enhancements to importing of group addresses, group attributes, and group attribute values.
Release Notes
What does the change add or fix in a succinct statement that will be read by clients?
Requested By
Who reported, requested, or paid for the change?
Warranty
Screenshots
Does this update or add options to the block UI?
no
Change Log
What files does it affect?
Migrations/External Impacts
Is it a breaking change for other versions/clients?
no